M2-6044: Submit Take Now Params #441
Conversation
sultanofcardio
force-pushed
the
feature/M2-6042-validate-take-now-params
branch
from
455e1a8 to
20d4334
Compare
sultanofcardio
force-pushed
the
feature/M2-6044-submit-take-now-params
branch
3 times, most recently
from
ace3725 to
10598bf
Compare
sultanofcardio
force-pushed
the
feature/M2-6044-submit-take-now-params
branch
from
10598bf to
d1271c6
Compare
sultanofcardio
requested review from
farmerpaul,
mbanting,
ChaconC,
moiskillnadne and
JustinNusca
|
Which branch of the backend do I need to test this with? I'm using The params are added as expected |
@ChaconC what's in the body of the error response? |
Looks like a problem when using take now on a Limited account. Full accounts work ok |
I'm not sure what the behaviour of the API should be in that case, but this flow doesn't support using a limited account as the |
There was a problem hiding this comment.
Hey @sultanofcardio, I'm currently struggling to get this to work. There may be some user error on my part, so I'm wading through that currently. But I've also discovered that it seems sourceSubjectId may not always be getting correctly initialized on the multiInformantState when the quiz starts (so not related to the code in this PR). It's time-consuming to figure out what's going on, so please bear with me. I just wanted to let you know before you merge so that in case I've discovered a bug, you can include the fix in this PR.
I'll keep you posted!
… flow We can get stuck in a weird state where the values in the state won't get updated, even if the new values from the params are different. By also comparing the values themselves, we can break out of this state
There was a problem hiding this comment.
After troubleshooting and figuring creating a workaround for a BE bug as mentioned in Slack, and testing again with your changes, all tests are now working. Thanks @sultanofcardio! 💪🏻
📝 Description
🔗 Jira Ticket M2-6044
This PR updates the code that submits the activity responses to
/answersto include the values fortarget_subject_idandsource_subject_id. The values are only included if theenableMultiInformantfeature flag is enabled.📸 Screenshots
N/A
🪤 Peer Testing
Note
This feature depends on the
enableMultiInformantfeature flag. If it it not already enabled, you can manually enable it here like so:features.enableMultiInformant = true;Note
There's an in-progress API patch that this PR depends on. If ChildMindInstitute/mindlogger-backend-refactor#1264 is still open when you are reviewing this PR, please use that branch as the basis for your API. Otherwise, you should use the
feature/multiinformant-metapodbranchFollow the peer testing steps in #438 and complete the activity that is opened with the network tab of dev tools open.
Look for the answer submission request and confirm that it includes the two fields
sourceSubjectIdandtargetSubjectId:✏️ Notes
N/A